qyriad/miden-crypto
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(dsa): fix deserialization logic (#266)

Browse source
This commit is contained in:
Michael Birch 2024-01-26 15:11:53 -05:00 • committed by Bobbin Threadbare
parent 70e39e7b39
commit 3882e0f719
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/dsa/rpo_falcon512/signature.rs
View file

@ -133,7 +133,7 @@ impl Deserializable for Signature {
let pk_polynomial = Polynomial::from_pub_key(&pk) let pk_polynomial = Polynomial::from_pub_key(&pk)
.map_err(|err| DeserializationError::InvalidValue(err.to_string()))? .map_err(|err| DeserializationError::InvalidValue(err.to_string()))?
.into(); .into();
let sig_polynomial = Polynomial::from_signature(&sig[41..]) let sig_polynomial = Polynomial::from_signature(&sig)
.map_err(|err| DeserializationError::InvalidValue(err.to_string()))? .map_err(|err| DeserializationError::InvalidValue(err.to_string()))?
.into(); .into();
@ -193,7 +193,7 @@ fn decode_nonce(nonce: &NonceBytes) -> NonceElements {
#[cfg(all(test, feature = "std"))] #[cfg(all(test, feature = "std"))]
mod tests { mod tests {
use super::{ use super::{
super::{ffi::*, Felt}, super::{ffi::*, Felt, KeyPair},
*, *,
}; };
use libc::c_void; use libc::c_void;
@ -268,4 +268,14 @@ mod tests {
let nonce = decode_nonce(&nonce); let nonce = decode_nonce(&nonce);
assert_eq!(res, hash_to_point(msg_felts, &nonce).inner()); assert_eq!(res, hash_to_point(msg_felts, &nonce).inner());
} }
#[test]
fn test_serialization_round_trip() {
let key = KeyPair::new().unwrap();
let signature = key.sign(Word::default()).unwrap();
let serialized = signature.to_bytes();
let deserialized = Signature::read_from_bytes(&serialized).unwrap();
assert_eq!(signature.sig_poly(), deserialized.sig_poly());
assert_eq!(signature.pub_key_poly(), deserialized.pub_key_poly());
}
} }