qyriad/miden-crypto
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bugfix: check if the requested root is in the storage

Browse source
This commit is contained in:
Augusto F. Hack 2023-03-16 23:26:02 +01:00
parent 931bcc3cc3
commit 669ebb49fb
No known key found for this signature in database
GPG key ID: 3F3584B7FB1DFB76
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/merkle/store.rs
View file

@ -235,6 +235,12 @@ impl MerkleStore {
/// This will return `NodeNotInStorage` if the element is not present in the store.
pub fn get_node(&self, root: Word, index: NodeIndex) -> Result<Word, MerkleError> {
let mut hash: RpoDigest = root.into();
// Check the root is in the storage when called with `NodeIndex::root()`
self.nodes
.get(&hash)
.ok_or(MerkleError::NodeNotInStorage(hash.into(), index))?;
for bit in index.bit_iterator().rev() {
let node = self
.nodes
@ -385,18 +391,6 @@ mod test {
Ok(())
}
#[test]
fn test_get_node_returns_self_for_root() {
let store = MerkleStore::default();
let root_idx = NodeIndex::new(0, 0);
// the root does not need any lookups in the storage itself, so the value is just returned
assert_eq!(store.get_node(LEAVES4[0], root_idx).unwrap(), LEAVES4[0]);
assert_eq!(store.get_node(LEAVES4[1], root_idx).unwrap(), LEAVES4[1]);
assert_eq!(store.get_node(LEAVES4[2], root_idx).unwrap(), LEAVES4[2]);
assert_eq!(store.get_node(LEAVES4[3], root_idx).unwrap(), LEAVES4[3]);
}
#[test]
fn test_get_invalid_node() {
let mut store = MerkleStore::default();